Skip force disconnection if transaction is open
What does this MR do and why?
Skip force disconnection if transaction is open
On CI, we can open a transaction for the duration of the RSpec run for
longer than 3600 seconds, because of TestProf::BeforeAll.adapter
.
After 3600 seconds, we need to not force disconnect so that tests don't fail due to a whole new PG connection. Otherwise we get errors like:
ActiveRecord::RecordNotFound:
Couldn't find Project with 'id'=950
Thanks to @stanhu for figuring out this root cause (#418757 (comment 1502138269)) !
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.