Skip to content

Fix the error loop function on JH side

Tao Heng requested to merge gitlab-jh/jh-team/gitlab:jh-fix-loop-error-in-review-apps-script into master

What does this MR do and why?

What: Change the curly brackets to parentheses.
Why: The image tzar/helm-kubectl:3.9.3 is using bash by default, and the For loop doesn't support variables in curly brackets - when the curl will run only one time.

We use the DNS service support by alicloud which's TTL is about 10 minutes. And on GitLab. Inc, there not have the same problem because your DNS service's TTL is much shorter.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tao Heng

Merge request reports