Skip to content

Fix empty state problem for pipeline schedules refactor

Payton Burdette requested to merge pb-fix-inactive-tab-state into master

What does this MR do and why?

When testing the rollout of pipeline_schedules_vue on a personal project. I found that when navigating to tabs that did not have data the empty state was shown. This MR fixes that issue to only show empty state when on the default tab scope.

Related epic: &6189 (closed)

Screenshots or screen recordings

Before After
Screenshot_2023-08-02_at_2.12.36_PM Screenshot_2023-08-03_at_9.50.55_AM

How to set up and validate locally

  1. In rails console enable the experiment fully
    Feature.enable(:pipeline_schedules_vue)
  2. Visit project with pipeline schedules (have one active and not inactive)
  3. Ensure empty state does not show on inactive tab
  4. Visit blank project, ensure empty state shows when visiting the schedules

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Payton Burdette

Merge request reports