Skip to content

Include subgroup and project users in group autocomplete

Heinrich Lee Yu requested to merge 417757-group-users-autocomplete into master

What does this MR do and why?

Changes the autocompletes in the group-level merge request list so that it also includes subgroup and descendant project members.

We want these users included in the autocomplete because even though they're not members of the parent group, they can be authors / assignees of the merge requests under the group if they are subgroup / project members.

This is part of #417757 (closed) to make autocompletes consistent across different pages / contexts.

Query changes

  1. Old query: https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/21060/commands/68812
  2. New query: https://postgres.ai/console/gitlab/gitlab-production-tunnel-pg12/sessions/21060/commands/68814

The old query is definitely much faster but the results are lacking because it does not include descendant members.

The main part of the new query has been reviewed in !126559 (merged) and this just adds the search and limit.

How to set up and validate locally

  1. Open the group-level MR list
  2. Trigger the autocomplete in the filter bar for the author, assignee, reviewer filters
  3. With the changes in this MR, it will now include descendant group / project users

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports