Skip to content

[E2E] Add a negated matcher for delete_issue_button

John McDonnell requested to merge jmd/project-owner-permissions-delete-issue-slow into master

What does this MR do and why?

Adds a negated matcher for has_delete_issue_button in the E2E tests.

Without this change, when we run something like expect(issue).not_to have_delete_issue_button it requires waiting the default max wait time (10 seconds) before returning, whereas with this change, the negated matcher will return as soon as it confirms the non presence of the element.

How to set up and validate locally

Noted this happening in 2 specs in project_owner_permissions_spec relating to without owner permissions. This change should speed these 2 specs up by 10 seconds each.

  • Data Stores Project owner permissions for group projects behaves like when user is added as maintainer has maintainer role without owner permissions

  • Data Stores Project owner permissions for personal projects behaves like when user is added as maintainer has maintainer role without owner permissions

  • bundle exec rspec './qa/specs/features/browser_ui/9_data_stores/project/project_owner_permissions_spec.rb'

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports