Skip to content

Remove unused params from Autocomplete::UsersFinder

Heinrich Lee Yu requested to merge remove-unused-autocomplete-users-params into master

What does this MR do and why?

Autocomplete::UsersFinder is only used by AutocompleteController and AutocompleteUsersResolver. The GraphQL field / resolver is newly added and does not have any of these arguments.

For the web controller, I checked the logs and they are unused. I also checked the frontend code and these are not used. These are remnants from when the member invite modal used this endpoint. That modal has since switched to using the REST API to list users.

This also moves the push_code param to CE since it's used in the project protected branch settings page for selecting users that can push to a protected branch. This is a CE feature so the param should be in CE. This is currently a bug where in CE, users who can't push aren't filtered out from the list. But it does not result in a vulnerability since permissions are still checked when they do the actual push.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Heinrich Lee Yu

Merge request reports