Skip to content

Support DiffPositionType of "file"

Mark Johnston requested to merge c3pmark/gitlab:diff-position-type into master

What does this MR do and why?

Support DiffPositionType of "file"

Gitlab::Diff::Position.position_type can be "file", so this needs to support the "file" position type.

Fixes #420666 (closed)

How to set up and validate locally

Sample project: https://gitlab.com/c3pmark/graphql-diff-position

Run in Graphiql:

{
  project(fullPath: "c3pmark/graphql-diff-position") {
    mergeRequest(iid: "1") {
      discussions {
        nodes {
          notes(first: 1000) {
            nodes {
              position {
                diffRefs {
                  baseSha
                  headSha
                  startSha
                }
                filePath
                positionType
                oldLine
                oldPath
                newLine
                newPath
              }
              url
              resolvable
              resolved
              userPermissions {
                resolveNote
                adminNote
              }
            }
          }
        }
      }
    }
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports