Skip to content

UI polish of super sidebar flyout menu

Dan Mizzi-Harris requested to merge danmh-super-sidebar-flyout-polish into master

What does this MR do and why?

While testing the super sidebar flyout menu I noticed some opportunites for UI polish.

  • Prevent shadow from being clipped / cut by overflow _unable to fix so reduced scope of MR !128104 (comment 1495410653) back in lets goooo _🚀
  • Update shadow to use Pajamas compliant version
  • Update border radius of nav item to be more harmonious with containing element

Related to Bring back hovering (#415343 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-08-01_at_11.30.32 Screenshot_2023-08-03_at_09.31.15
Screenshot_2023-08-01_at_11.32.13 Screenshot_2023-08-03_at_09.31.22

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable the feature flag using gdk rails c Feature.enable(:super_sidebar_flyout_menus)
  2. Navigate to a project or group
  3. Using a mouse, hover the nav items

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan Mizzi-Harris

Merge request reports