Skip to content

Unquarantine project service blob and commit

Jennifer Li requested to merge jennli-pjt-svc-blob-and-cmt into master

What does this MR do and why?

Resolves flaky spec reported in #418757 (closed)

I was not able to reproduce this with --bisect, but we know let_it_be_with_refind forces a hard reload, which should be more reliable than let_it_be_with_reload, so I propose we merge this fix and observe if this removes the flakiness from the spec.

Due to https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/support/helpers/project_helpers.rb#L9:

project.update!(params.merge(additional_params))

project is being mutated in this step, so the shared project record risks having leaked state.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jennifer Li

Merge request reports