Skip to content

Update tags criteria to show by default

Alexander Turinske requested to merge 419681-update-tags-criteria into master

What does this MR do and why?

Update tags criteria to show by default

  • show runner tags by default
  • update default policy to not include empty array for tags
  • make runner tag filter permanent
  • remove "tags" property when no tags are selected
  • remove unnecessary label
  • update tests

Changelog: changed

EE: true

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
tags_-_before tags_-_after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate licence
  2. Navigate to a project/group => Secure => Policies => New policy => Scan execution
  3. Runner tags criteria UI should be visible by default and permanent and set to "selected automatically"
  4. Select "specific" and select some tags
  5. Verify the tags property appears in the yaml
  6. Remove all the tags
  7. The tags property should not be in the yaml
  8. Navigate to yaml mode and add some variables
  9. Navigate back to rule mode, the tags should be selected

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #419681 (closed)

Edited by Alexander Turinske

Merge request reports