Skip to content

CI/CD Settings Variables: use GlCard

Sascha Eggenberger requested to merge ci-cd-settings-variables into master

What does this MR do and why?

Uses GlCard for CI/CD Settings Variables:

  • Use of GlCard
  • Moves the add button & value toggle to the top
  • Adds the ability to delete items inline

Screenshots or screen recordings

Admin

Before After
admin_var_empty_before admin_var_empty
admin_var_content_before admin_var_content

Group

Before After
group_var_empty_before group_var_empty
group_var_content_before group_var_content

Project

Before After
project_content_before project_empty_after
project_empty_before project_content_after

How to set up and validate locally

  1. Admin: http://gdk.test:3000/admin/application_settings/ci_cd
  2. Group: http://gdk.test:3000/groups/flightjs/-/settings/ci_cd
  3. Project: http://gdk.test:3000/flightjs/Flight/-/settings/ci_cd

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related UX Paper Cuts 16.3 → Settings UI, part 2 (#417912 - closed), [META] Migrate settings pages with an add form ... (#419105 - closed)

Edited by Sascha Eggenberger

Merge request reports