Skip to content

De-quarantine and fix security reports spec flakiness

Harsha Muralidhar requested to merge hm-dequarantine-security-reports-spec into master

What does this MR do and why?

De-quarantine and fix security reports spec flakiness. Attempts to address: #420136 (closed)

Most of the failures from the above issue are because the vulnerability report is not loaded yet after pipeline success. This MR addresses the following flakiness:

  • The failure when trying to click on the tool filter (sometimes) by adding a wait.
  • The failure when trying to fetch the :id of completed pipeline belonging to the project by using unless pipelines.empty?
  • The failure when trying to click on the project path text in group security dashboard by adding a retry.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

WEBDRIVER_HEADLESS=false GITLAB_ADMIN_PASSWORD="XXXX" GITLAB_QA_ACCESS_TOKEN=XXXXX GITLAB_PASSWORD="XXXXX" QA_LOG_LEVEL=DEBUG QA_GITLAB_URL=http://172.30.0.158:3000 bundle exec rspec ./qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports