Skip to content

Remove override for vue/multi-word-component-names

Miguel Rincon requested to merge 360551-add-warn-to-disabled-rule-also-ee into master

What does this MR do and why?

This change adds linting to non-EE .vue files to ensure we use two words in their name with "vue/multi-word-component-names".

This change is important as we have some usages of components that have the same name as some HTML tags, like form and table.

MR
Enable vue/multi-word-component-names lint rule (!127929 - merged)
Remove override for vue/multi-word-component-names (!127930 - merged) 👇 you're here!

Reviewing this MR

  1. You may start by checking the changes in .eslintrc.yml.
  2. All other changes are to eslint-disable in the files affected
  3. See more on the rationale behind this change in the docs update at !127929 (5ad6ec8c) (already merged)

Screenshots or screen recordings

NA

Command to re-apply eslint-disable in all files

We can use this in case of merge conflicts:

for file in $(yarn eslint **/*.vue | grep app/assets/javascripts); do sed -i '' '1 s/^/<!-- eslint-disable vue\/multi-word-component-names -->\n/' ${file}; done

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #360551 (closed)

Edited by Miguel Rincon

Merge request reports