Draft: Extract shared constants for Issues and Service Desk lists
What does this MR do and why?
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #418920 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @psjakubowska
mentioned in issue gitlab-org/monitor/respond#260 (closed)
mentioned in issue gitlab-org/monitor/respond#263 (closed)
added 1388 commits
-
0057a4f7...3e777e4c - 1387 commits from branch
master
- 4d358542 - Move shared PARAM_* consts
-
0057a4f7...3e777e4c - 1387 commits from branch
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 1 hour ahead of@psjakubowska
)Jose Ivan Vargas (
@jivanvl
) (UTC-6, 8 hours behind@psjakubowska
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/monitor/respond#264 (closed)
changed milestone to %16.4
added missed:16.3 label
added 2790 commits
-
4d358542...a2a49ea6 - 2789 commits from branch
master
- 63ff1080 - Move shared PARAM_* consts
-
4d358542...a2a49ea6 - 2789 commits from branch
added 1 commit
- 7f55539e - Extract consts for sorting within IssuableList
mentioned in issue gitlab-org/monitor/respond#266 (closed)