Skip to content

Remove accent color as active color from tabs

Sascha Eggenberger requested to merge remove-accent-color into master

What does this MR do and why?

Removes the theme accent color from the following elements:

  • Emoji picker tabs
  • Tabs
  • Removes unused code from the editor refactoring on the MR review summary

Related MR for GitLab UI: feat(tabs): Remove theme color (gitlab-ui!3597 - merged)

Why this change?

The new navigation uses a fixed blue active indicator. As the theme color is not used in a lot of places and to keep things consistent in the UI we should remove the themes active state of the tabs to match other component's active state.

This might be a temporarily change until we have a more holistic approach how to handle theming in the future.

Screenshots or screen recordings

Before After
mr_tabs_before mr_tabs_after
emoji_picker_before emoji_picker_after
mr_review_summary

How to set up and validate locally

  1. Go to the settings and select a theme color like red
  2. Go to an MR, e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/3
  3. Check tabs, emoji picker and review summary and make sure the theme color is no longer seen

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #417912 (closed)

Edited by Frédéric Caplette

Merge request reports