Skip to content

Add settings section

Alexander Turinske requested to merge 418751-add-project-approval-setting into master

What does this MR do and why?

Add settings section

  • add :scan_result_policy_settings feature flag
  • add block_uprotecting_branches setting to scan result policy
  • allow for it to be disabled
  • add tests

Changelog: added

EE: true

Screenshots or screen recordings

Note: The designs show the section as collapsible; that is coming in a follow-up

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Page ff off ff on
New policy Screenshot_2023-07-26_at_14.29.17 image
Yaml image image
Existing policy No change image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Toggle the feature flag with the below
echo "Feature.disable(:scan_result_policy_settings)" | rails c
  1. Navigate to a project/group => Secure => Policies => New policy => Scan result policy
  2. Verify setting updates appropriately and changes if changed in yaml mode

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #418751 (closed)

Edited by Alexander Turinske

Merge request reports