Convert OmniAuth login buttons to Pajamas
What does this MR do and why?
Closes #417814 (closed)
-
Extracted OmniAuth login buttons to a HAML partial and use the new partial in two places.
-
Prepended classes and ids associated to JavaScript functionality with
js-.... This allows better searchability and maintainability. -
Replaced a static fixture to a generated fixture. This allows checking real DOM changes.
-
Remove unnecessary classes.
-
Some other minor changes, improved structure of tests, etc.
Changelog: changed
EE: true
Screenshots or screen recordings
Slightly reduce the vertical spacing between the buttons in some cases.
Old style
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
New style
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
On an incognito window check go to one of these pages:
- /users/sign_in
- /users/sign_up
- /-/trial_registrations/new (SaaS emulation required)
To check that the form actions and the buttons href reflects the fragment redirect:
- On an incognito window go to: /users/sign_in#testhello
- Search for
testhelloin the DOM - Play with the
Remember mebutton in the OmniAuth buttons. - See the changes in the button href.
Screen_Recording_2023-07-26_at_18.16.59
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.