Skip to content

Draft: Cleanup `ci_variables_pages` feature flag

Mireya Andres requested to merge ma/cleanup-ci-variables-pages into master

What does this MR do and why?

For #392874

With this, CI Variables settings for instances, groups, and projects will have pagination enabled by default for the CI variables table.

Screenshots or screen recordings

Admin admin
Group group
Project project

How to set up and validate locally

  1. Make sure the feature flag is disabled.

    Feature.disable(:ci_variables_pages)

  2. You can use the following command to seed your instance/group/project with CI variables. (Docs)

    bundle exec rake "gitlab:seed:ci_variables_instance[25]"
bundle exec rake "gitlab:seed:ci_variables_group[group_name, 25]"
bundle exec rake "gitlab:seed:ci_variables_project[project_path, 25]"

  3. For your instance/group/project, go to Settings > CI/CD > and expand the Variables section.

  4. Verify that pagination works.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports