Skip to content

Remove feature flag remove_deployments_api_sort_ref

Hunter Stewart requested to merge hustewart-remove-remove_deployments_api_ref_sort into master

What does this MR do and why?

Feature Flag clean up of remove_deployments_api_sort_ref

In !124229 (merged) it was simpler to handle the logic as the one liner rather than conditionally defining the constant to include or not include 'ref'.

Now that the feature flag is being removed and the behavior has been rolled out to production, I think it is simpler to remove the one liner and remove 'ref' from ALLOWED_SORT_VALUES.

The logic in the affected method build_sort_params already does the desired behavior if we remove 'ref' from the method.

This commit also:

  • removes the feature flag yaml.
  • updates the spec for feature flag removal.

Changelog: fixed

Related: Remove remove_deployments_api_ref_sort (!125451 - closed) which was closed at the time so that we could keep the feature flag in 16.2 and clean it up in 16.3

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hunter Stewart

Merge request reports