Do not store chat messages by default
What does this MR do and why?
Related issue: #419596 (closed)
We no longer want to store and show AI messages on the chat, if not
explicitly enabled by the feature. It is now only enabled for the chat
AI action.
We do this by setting skip_cache = true
by default.
It also fixes a bug where the skip_cache
was not passed along properly
to the GraphqlSubscriptionResponseService.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- Enable AI features https://docs.gitlab.com/ee/development/ai_features.html#test-ai-features-locally
Feature.enable(:gitlab_duo, true)
- Go to a page that has AI features, e.g. Vulnerabilities, or an Issue.
- Use the AI feature, e.g. summarize issues or Explain Vulnerabilities
- Refresh the browser and Open the GitLab Duo chat
- This is a necessity to test the feature, because right now, the chat listens on the AiCompletionResponseSubscription - and adds it to the chat, regardless of the action performed. This is another problem that needs to be tackled, also see #413600 (comment 1485444913)
- Before: You'd see the answer from the AI in the chat, Now: You no longer see the response because we don't store the message for the chat.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.3
added groupai framework label
assigned to @nicolasdular
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs (
@alexbuijs
) (UTC+2, same timezone as@nicolasdular
)Bojan Marjanović (
@bmarjanovic
) (UTC+2, same timezone as@nicolasdular
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 3822cfb1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Manage | 12 | 1 | 1 | 0 | 14 | ❌ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 145 | 1 | 4 | 0 | 150 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label(s) ~"Category:GitLab Duo Chat" devopsmodelops sectiondata-science based on groupai framework.
added devopsmodelops sectiondata-science labels
mentioned in merge request !122647 (merged)
- Resolved by Bojan Marjanovic
- Resolved by Nicolas Dular
requested review from @acroitor
removed sectiondata-science label
added sectiondata-science label
@acroitor
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @acroitor
Setting label(s) ~"Category:GitLab Duo Chat" based on groupai framework.
mentioned in issue #419948 (closed)
- Resolved by Bojan Marjanovic
Hey @bmarjanovic, Could you please take over the maintainer review? Thanks!
requested review from @bmarjanovic
enabled an automatic merge when the pipeline for 42380383 succeeds
mentioned in commit 0a500b3b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !128263 (merged)
mentioned in issue bmarjanovic/growth-and-development#1
added releasedcandidate label
added devopsai-powered label and removed devopsmodelops label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2364 (merged)