Skip to content
Snippets Groups Projects

Do not store chat messages by default

Merged Nicolas Dular requested to merge nd/do-not-cache-ai-actions into master
All threads resolved!

What does this MR do and why?

Related issue: #419596 (closed)

We no longer want to store and show AI messages on the chat, if not explicitly enabled by the feature. It is now only enabled for the chat AI action. We do this by setting skip_cache = true by default.

It also fixes a bug where the skip_cache was not passed along properly to the GraphqlSubscriptionResponseService.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. Enable AI features https://docs.gitlab.com/ee/development/ai_features.html#test-ai-features-locally
  2. Feature.enable(:gitlab_duo, true)
  3. Go to a page that has AI features, e.g. Vulnerabilities, or an Issue.
  4. Use the AI feature, e.g. summarize issues or Explain Vulnerabilities
  5. Refresh the browser and Open the GitLab Duo chat
    1. This is a necessity to test the feature, because right now, the chat listens on the AiCompletionResponseSubscription - and adds it to the chat, regardless of the action performed. This is another problem that needs to be tackled, also see #413600 (comment 1485444913)
  6. Before: You'd see the answer from the AI in the chat, Now: You no longer see the response because we don't store the message for the chat.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nicolas Dular

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Dular
  • Author Maintainer

    Hey @acroitor, Do you mind performing a backend review for this merge request, please? :) Thanks!

  • Nicolas Dular requested review from @acroitor

    requested review from @acroitor

  • Alexandru Croitor approved this merge request

    approved this merge request

  • :wave: @acroitor, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Alexandru Croitor removed review request for @acroitor

    removed review request for @acroitor

  • Setting label(s) ~"Category:GitLab Duo Chat" based on groupai framework.

  • mentioned in issue #419948 (closed)

  • Nicolas Dular requested review from @bmarjanovic

    requested review from @bmarjanovic

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • Bojan Marjanovic approved this merge request

    approved this merge request

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • Bojan Marjanovic enabled an automatic merge when the pipeline for 42380383 succeeds

    enabled an automatic merge when the pipeline for 42380383 succeeds

  • Bojan Marjanovic mentioned in commit 0a500b3b

    mentioned in commit 0a500b3b

  • added workflowstaging label and removed workflowcanary label

  • Nicolas Dular mentioned in merge request !128263 (merged)

    mentioned in merge request !128263 (merged)

  • added devopsai-powered label and removed devopsmodelops label

  • Please register or sign in to reply
    Loading