Skip to content

Denormalise banned users on merge requests table

Robert May requested to merge faster-banned-users-mr-list into master

What does this MR do and why?

Denormalise banned users on merge requests table. Will drop about 250ms off of the merge requests list page on .com, e.g. https://gitlab.com/gitlab-org/gitlab/-/merge_requests.

This adds an author_banned boolean to the merge_requests table which is updated as users are banned/unbanned, which then vastly simplifies the query to fetch only merge requests by unbanned users. This also adds an index to cover the adjusted query.

Changelog: performance

Closes Denormalise banned users on merge requests table (#432774)

Screenshots or screen recordings

Screenshot_2023-07-25_at_15.05.13

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sean Carroll

Merge request reports