Delete pod dashboard service class and usages
What does this MR do and why?
Deletes PodDashboardService class and its usage in other places.
Helps move #397139 (closed) forward. The files in this MR are already staged for deletion. I am deleting them in small numbers to reduce the negative impact if any and keep the MR size small.
Screenshots or screen recordings
NA
How to set up and validate locally
- Pipeline should be
- Pods dashboard should not show up in any of the dashboard finders.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397139 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @rkadam3
- Resolved by Vitali Tatarintev
1 Warning 30cf21ab: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sylvester Chin (
@schin1
) (UTC+8, 2.5 hours ahead of@rkadam3
)Brian Williams (
@bwill
) (UTC-5, 10.5 hours behind@rkadam3
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for e3b14825expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Create | 27 | 0 | 1 | 0 | 28 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 13 | 0 | 1 | 0 | 14 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 4 | 0 | 150 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for e3b14825expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 555 | 0 | 89 | 0 | 644 | ✅ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Govern | 158 | 0 | 12 | 0 | 170 | ✅ | | Plan | 246 | 0 | 10 | 0 | 256 | ✅ | | Manage | 159 | 0 | 12 | 0 | 171 | ✅ | | Package | 232 | 0 | 11 | 0 | 243 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Verify | 144 | 0 | 15 | 0 | 159 | ✅ | | Monitor | 36 | 0 | 7 | 0 | 43 | ✅ | | Release | 18 | 0 | 0 | 0 | 18 | ✅ | | Fulfillment | 8 | 0 | 72 | 0 | 80 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Secure | 6 | 0 | 27 | 0 | 33 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 3 | 0 | 3 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1697 | 0 | 282 | 0 | 1979 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Vitali Tatarintev
@splattael - Mind taking a direct maintainer review on this one, please?
Thanks!
requested review from @splattael
added 96 commits
-
b5bd504e...d8c1b8a2 - 93 commits from branch
master
- 30cf21ab - Delete pod dashboard service class and usages
- 70290aa5 - Update translations for strings
- e3b14825 - Delete unused pod_metrics.yml
Toggle commit list-
b5bd504e...d8c1b8a2 - 93 commits from branch
@rkadam3 Some end-to-end (E2E) tests have been selected based on the stage label on this MR.Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing before this MR is merged.If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in
e2e:package-and-test
pipeline.For the list of known failures please refer to the latest pipeline triage issue.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
added pipeline:run-all-e2e label
mentioned in issue gitlab-org/monitor/respond#260 (closed)
requested review from @ck3g and removed review request for @splattael
@ck3g
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 8f503747 succeeds
mentioned in commit ec2c326c
added workflowstaging-canary label and removed workflowblocked label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#263 (closed)
mentioned in issue gitlab-org/monitor/respond#264 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#266 (closed)