Allow verification of files in Object Storage (Filesize check)
What does this MR do and why?
This MR adds Geo verification of OS-stored files via comparison of file sizes.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #13845 (closed)
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @vsizov
- A deleted user
added backend feature flag featureaddition typefeature labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rutger Wessels (
@rutgerwessels
) (UTC+2)Aleksei Lipniagov (
@alipniagov
) (UTC+2)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4924692e
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 72d54886expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 38 | 0 | 0 | 2 | 38 | ❗ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 20 | 0 | 0 | 1 | 20 | ❗ | | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Plan | 47 | 0 | 0 | 0 | 47 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 159 | 0 | 1 | 3 | 160 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 72d54886expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
added 952 commits
-
390e8fbd...b1816870 - 951 commits from branch
master
- 2b4363c7 - Allow verification of files in Object Storage
-
390e8fbd...b1816870 - 951 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ec949c96
- A deleted user
added databasereview pending label
added 2493 commits
-
2b4363c7...53f10e22 - 2492 commits from branch
master
- cdb6db3e - Allow verification of files in Object Storage
-
2b4363c7...53f10e22 - 2492 commits from branch
added 1 commit
- 8588359a - Allow verification of files in Object Storage
- Resolved by Douglas Barbosa Alexandre
@mkozono Can you take a look at this Draft. It works localy already. Any suggestions?
It works with GCS and Amazon S3.
- Resolved by Douglas Barbosa Alexandre
added 893 commits
-
8588359a...03912ac2 - 891 commits from branch
master
- 87484f36 - Allow verification of files in Object Storage
- c0840f87 - Add specs
-
8588359a...03912ac2 - 891 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@40380f44
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@abb67cf8
requested review from @aakriti.gupta
mentioned in issue #13845 (closed)
- Resolved by Valery Sizov
- Resolved by Aakriti Gupta
- Resolved by Aakriti Gupta
- Resolved by Aakriti Gupta
I have reviewed the merge request and left two questions and one suggestion as comments. The questions are about the reasons for removing the tests and the possibility of creating
model_record
only once outside the tests. The suggestion is to add the introduced_by_url to the commit message. I estimate that a small amount of work is required to address these comments.
@aakriti.gupta
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @aakriti.gupta
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@432c4caf
added 778 commits
-
87207fb7...ca09e89e - 777 commits from branch
master
- 147b538b - Allow verification of files in Object Storage
-
87207fb7...ca09e89e - 777 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@0f04da86
added 1 commit
- 9c807191 - Allow verification of files in Object Storage
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@730badba
added 1 commit
- e20e4909 - Allow verification of files in Object Storage
requested review from @aakriti.gupta
requested review from @mkozono and removed review request for @aakriti.gupta
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e9e15bc4
mentioned in issue #423112 (closed)
- Resolved by Douglas Barbosa Alexandre
@dbalexandre @aakriti.gupta or @mkozono could one of you take this over from Valery? Thanks!
requested review from @dbalexandre and removed review request for @mkozono
assigned to @aakriti.gupta
added 773 commits
-
e20e4909...cfc8cda3 - 772 commits from branch
master
- 72d54886 - Allow verification of files in Object Storage
-
e20e4909...cfc8cda3 - 772 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@62d15cd4
unassigned @vsizov
enabled an automatic merge when the pipeline for 75283d2d succeeds
Thanks, @vsizov @aakriti.gupta! This LGTM
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@75283d2d
mentioned in commit d33cde7e
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #410387 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2437 (merged)
mentioned in issue gitlab-org/quality/triage-reports#15303 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15730 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16034 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16496 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17027 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17474 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17933 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18466 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18954 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19406 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20616 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20981 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21533 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22038