Skip to content

Move rubocop check to pre-commit hook

Kerri Miller requested to merge kerrizor/move-rubocop-to-pre_commit into master

What does this MR do and why?

Running rubocop checks on git push is frustrating, as correcting any errors requires either a new commit or an --amend. By moving rubocop checks to pre-commit, we can instead prevent issues it complains about from entering the tree entirely, helping users to prevent stubbing their toe when they later attempt to push.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports