Skip to content

Fix "pending deletion" badge

What does this MR do and why?

Related to #419337 (closed)

In !122524 (merged) we switched the API that is used for the Archived projects tab on group overview. It was missed that marked_for_deletion_at is only available on EE when a condition is true. This caused a regression where the "pending deletion" badge was always shown on CE. This MR fixes the logic so the "pending deletion" badge is only shown when marked_for_deletion_at is present and has a value set.

Screenshots or screen recordings

Before After
Screenshot 2023-07-21 at 9.33.39 AM.png Screenshot 2023-07-21 at 9.32.58 AM.png

How to set up and validate locally

  1. Remove your license (make sure you know where the original is so you can add it back after)
  2. Go to a group
  3. Create a project in that group
  4. In the project go to Settings -> General -> Advanced . Click Archive project
  5. Go to the group overview and click Archived projects tab. The project should not have a pending deletion badge.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports