Delete UsersStarredDashboardsFinder class and specs
What does this MR do and why?
Deletes UsersStarredDashboardFinder class and specs that was not used anywhere else.
Helps move #397139 (closed) forward.
Screenshots or screen recordings
NA
How to set up and validate locally
- This class was not used anywhere, so I think we may not need any testing here and completely rely on pipeline being
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #397139 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @rkadam3
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for cc8643d9expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 0 | 40 | 47 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Govern | 19 | 0 | 0 | 18 | 19 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 129 | 0 | 1 | 111 | 130 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Peter Leitzen
@sdungarwal - Can you take initial review on this one, please?
If looks good, please pass on to
@splattael
for maintainer review.Thanks!
requested review from @sdungarwal
@sdungarwal
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @splattael
removed review request for @sdungarwal
mentioned in issue gitlab-org/monitor/respond#255 (closed)
enabled an automatic merge when the pipeline for 0c4cf3be succeeds
mentioned in commit fd49b110
added workflowstaging-canary label and removed workflowblocked label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#260 (closed)
mentioned in issue gitlab-org/monitor/respond#263 (closed)
mentioned in issue gitlab-org/monitor/respond#264 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#266 (closed)