Skip to content

Add loading state to shared dashboard listing

Elwyn Benson requested to merge 396711-dashboards-list-loading-state into master

What does this MR do and why?

Adds a loading state to the dashboards list.

Displays 2 sets of skeleton loaders (matching the 2 builtin Audience/behaviour dashboards we know will exist at minimum). 2 rows per skeleton to match the content.

Also updates the existing page-level loading spinner, which is now a skeleton also, in order to match our Pajamas guidance around mixing spinners and skeletons.

Note2: this feature is experimental and behind default-off feature flags.

Screenshots or screen recordings

Before After
image image

loading-skeletons

How to set up and validate locally

  1. Follow these instructions to setup Product Analytics in GDK.
  2. Visit the dashboards list for a not-yet-onboarded project at Project -> Analyze -> Analytics dashboards
  3. Verify the onboarding list item shows correctly. There should be no visible loading state in this case
  4. Visit the dashboards list for an already-onboarded project
  5. Verify loading state is shown while fetching dashboards

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #396711 (closed)

Edited by Elwyn Benson

Merge request reports