Skip to content

Render textual LFS files in UI

Joe Woodward requested to merge feature/render-lfs-files into master

What does this MR do and why?

Render textual LFS files in UI

Fixes #383436 (closed)

Prior to this change we would never render LFS files with fileType: 'text'. Instead we would render the pointer in the UI.

Changelog: fixed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image

How to set up and validate locally

  1. Configure GDK with lfs
  2. Create a new project called render-lfs-pointers inside gitlab-org (if you don't have gitlab-org create somewhere else but remember to update the commands coming up)
  3. Clone the project git remote add origin ssh://git@gdk.test:2222/gitlab-org/.git
  4. Create a non-binary lfs file e.g. echo 'test' > test.text
  5. Track *.text in lfs git lfs track '*.text'
  6. git add . && git commit -m 'Create lfs file' && git push origin main
  7. open gdk.text:3000/gitlab-org/render-lfs-pointers/-/blob/main/test.text
  8. Check the blob is rendered

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Joe Woodward

Merge request reports