Skip to content

Prevent loading state from showing after undo

Himanshu Kapoor requested to merge 419095-loading-after-undo into master

What does this MR do and why?

Prevent loading state from showing after undo

In rich text editor, after you paste some text, the loading indicator disappears. But if you undo, it reappeared. This commit fixes that.

Changelog: fixed

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screen Recording 2023-07-20 at 01.40.05.mov Screen Recording 2023-07-20 at 01.38.31.mov

How to set up and validate locally

  1. Open an issue, scroll down to the comment box.
  2. Throttle your connection to "Slow 3G" in the Network tab (Chrome Developer tools).
  3. Copy some content from an existing comment.
  4. Paste. Note a delay in the paste, during which time a loading indicator appears.
  5. Press Cmd + Z to undo.
  6. The loading indicator should not appear again. (It previously did.)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #419095 (closed)

Merge request reports