Skip to content

Add no hard coded url eslint rules for spec files

Kun Qian requested to merge gitlab-jh/jh-team/gitlab:add-no-hard-url-in-template-literal into master

What does this MR do and why?

This is a follow up MR of !125196 (merged),

this MR:

  1. Add no hard coded url eslint rules for spec files
  2. Add no hard coded url check for template literal
  3. Adjust regular expression to match template literal of multiple lines
  4. fix a bug that ${DOCS_URL}/ee was not throwing error message to use DOCS_URL_IN_EE_DIR.

Screenshots or screen recordings

How to set up and validate locally

  1. yarn run lint

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

cc @daveliu @JeremyWuuuuu @fenyuluoshang

Edited by Kun Qian

Merge request reports