Finding modal: Fix toast when undoing dismissal
What does this MR do and why?
Finding modal: Fix toast when undoing dismissal
Currently, when a dismissal is undone, the report shows an incorrect toast message. This change fixes that and aligns it with the behaviour of the previous modal, which is to show no toast message at all.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
| Screen Recording 2023-07-17 at 3.44.03 pm.mov | Screen Recording 2023-07-17 at 3.45.22 pm.mov |
How to set up and validate locally
- Go to a project's pipeline and click "Security"
- Dismiss a finding
- Toggle "Hide dismissed", so that dismissed findings get show
- Click on the dismissed finding and then "Undo dismiss"
- Verify that the toast message does not pop up
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #418793 (closed)
Edited by David Pisek