Skip to content

Reuse same Pajama compliant HAML in two places

Eduardo Sanz García requested to merge eduardosanz/pajama-otp-migration into master

What does this MR do and why?

Extracted Pajama compliant form from app/views/devise/sessions/two_factor.html.haml and reused in app/views/admin/sessions/two_factor.html.haml. Removed non-compliant version: app/views/admin/sessions/_two_factor_otp.html.haml

This remove a non-compliant Pajamas button.

Changelog: changed

Screenshots or screen recordings

No changes

How to set up and validate locally

  1. On an incognito window, sign with a user that has two-factor enabled.
  2. Enable Admin Mode, with an admin user that has two-factor enabled, enter Admin Mode.

No changes should be noticed.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Sanz García

Merge request reports