Skip to content

Show new streaming destinations first in list

Lorenz van Herwaarden requested to merge add-new-destinations-to-beginning into master

What does this MR do and why?

Related #416324 (closed)

When creating a new HTTP endpoint of GCP Cloud Logging audit streaming destination, it will appear as first in the list (of respective http endpoints/gcp cloud logging items) which is the order we also retrieve from the backend. This way, when you refresh the page, the order stays the same.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
order-before order-after

How to set up and validate locally

You'll need an ultimate license

Go to audit event streams of a group, like e.g. http://gdk.test:3000/groups/gitlab-org/-/audit_events?tab=streams

  • make sure you've already got at least 1 http endpoint and 1 gcp cloud logging destination ("Add streaming destination")
  • create another http endpoint destination and make sure after adding it, it appears before the other http endpoint
  • create another gcp cloud logging destination and make sure after adding it, it appears before the other gcp cloud logging destination
  • refresh the page and validate that the order of the destinations has remained the same

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lorenz van Herwaarden

Merge request reports