Skip to content

Delete actions_button component

Enrique Alcántara requested to merge delete-actions-button-component into master

What does this MR do and why?

Deletes the` actions_button.vue` component and replace its usage with the GlDisclosureDropdown component in web_ide_link.vue

actions_button.vue is only used in web_ide_link.vue and it doesn't provide a meaningful abstraction on top of GlDisclosureDropdown.

Motivation

We recently implemented an enterprise version of the web_ide_link.vue component. The EE version extends the CE version using slots. CE- web_ide_link.vue renders the dropdown component using actions_button.vue . This design decision complicates all the changes that require interacting with GlDisclosureDropdown like listening to its events or adding new slots. Using GlDisclosureDropdown in web_ide_link.vue simplifies these kind of changes.

Screenshots or screen recordings

This Merge Request doesn't introduce user-facing changes. It is a refactoring.

How to set up and validate locally

You can use the "Edit" dropdown that appears in the Repository and blob views.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Enrique Alcántara

Merge request reports