Skip to content

Migrate project Star button to Vue

Andrew Smith requested to merge espadav8/gitlab:convert-star-count-to-vue into master

What does this MR do and why?

Currently the Star button is completely rendered in the HAML file. This is the start of a port of that button into a Vue component.

Notes about this MR

image

This MR is touching a Vue app heavy part of the page. The plan with this is to port this middle component into a Vue app and then combine the 3 apps (initVueNotificationsDropdown, initVueStarCount, and initForksButton) into a single one.

As it currently stands, initVueNotificationsDropdown and initForksButton are both Vue apps, but with the Star Count sitting in-between them, they can't be combined yet.

How to set up and validate locally

  • Clone this MR
  • Visit a project page (I use flightjs)
  • Check that the Star button looks the same

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Ref Improve project star button (#431567 - closed)

Edited by Andrew Smith

Merge request reports