Skip to content

Resolve "Do not fetch all public groups for approval rule when search is empty"

What does this MR do?

This MR updates the groups search for approval rules to only search for all public groups when a search term is present (i.e. all_available=true). Otherwise, when the search term is empty, it will only show groups which the user is a member of (i.e. all_available=false).

Screenshot

(Notice how "cool-public-group" doesn't show up unless it's specifically searched for)

20190513_dont_show_all_available_on_empty

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Links

Edited by Paul Slaughter

Merge request reports