Skip to content

Always show 'Save Changes' button when searching in user's preferences

Pierre-Antoine Porte requested to merge pap-always-show-save-changes-in-preferences-when-searching into master

What does this MR do and why?

This MR changes the behaviour of the "Save Changes" button in the User's preferences webpage. It always shows the button. Reasoning behind this change is that users are used to (that's been the experience of 2 colleagues and I) auto-saving changes, or seeing a button directly. When trying to enable Code suggestions (by searching in the search bar), we left the page without saving (which could itself yield a warning). I believe that if we saw the "Save Changes", we would have clicked on it.

The button is still shown if the search yields no results. I don't know if this should be expected or not, just noting it.

Screenshots or screen recordings

Before:

initial-behavior

After:

fix-show-changes

How to set up and validate locally

  1. Go to users' preferences pages http://127.0.0.1:3000/-/profile/preferences
  2. Search anything (that shows results)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports