Skip to content

Fix pipeline MR failures widget popovers

Frédéric Caplette requested to merge fc-fix-failures-mr-popover into master

What does this MR do and why?

The popover for the pipeline failures MR widget were all stackign on top of each others because they all had the same id 😅 This MR fixes this small visual issue.

This is behind a disabled feature flag, ci_job_failures_in_mr

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screen_Recording_2023-07-12_at_11.37.17_AM Screen_Recording_2023-07-12_at_11.35.35_AM

How to set up and validate locally

  1. Enable feature flag in rails console `Feature.enable(:ci_job_failures_in_mr)
  2. Make sure to have a functioning runner
  3. We need a MR with jobs failures. An easy to do so is to make a merge request on the ci config file and add explicit failures
  4. Navigate to Build -> Pipeline Editor
  5. Change your config to include jobs failures like so:
my_failed_job:
  script: exit 1

my_failed_job2:
  script: exit 1

my_failed_job3:
  script: exit 1
  1. Create a merge request with that change
  2. Navigate to the Merge request page
  3. Go to the pipelines page
  4. Click on show failed jobs
  5. Hover on the info icon
  6. Notice the popover appears correctly
  7. Hover on each info icon
  8. Notice they all appear fine

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports