Skip to content

Add feature flag for CI variables drawer

Mireya Andres requested to merge ma/ci-variable-drawer-ff into master

What does this MR do and why?

For #410414 (closed)

The drawer will replace the modal form for creating, editing, and deleting CI Variables.

This MR is purely for the rendering the drawer under the feature flag. Interactions with the UI (such as validations and submitting the form) will be implemented in future iterations.

The MR is broken down into different commits for: 1) showing the drawer under a feature flag; 2) scaffolding the component with UI elements. The feature flag will be rolled out on a user actor basis because the CI variables setting exists on the instance-level, group-level, and project-level. The drawer/modal component is shared in all three contexts.

No changelog entry yet since this will be developed under the ci_variable_drawer feature flag.

Implementation

Iteration MR
Setup drawer with feature flag 👈 You are here!
Add form validations
Ensure that all mutations are working and update QA specs
Rollout #418005 (closed)

Screenshots or screen recordings

Before After
modal Screenshot_2023-07-18_at_18.37.57

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Enable the ci_variable_drawer feature flag.
  2. Go to Settings > CI/CD > Variables.
  3. Click on the Add variable button or edit a variable.
  4. The drawer should show up instead of the modal.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports