Skip to content

Decouple tests from internal structure of toggle component

Janis Altherr requested to merge janis-fix-failing-tests-for-toggle into master

What does this MR do and why?

This (hopefully) fixes https://gitlab.com/gitlab-org/gitlab/-/jobs/4570293128 which prevented gitlab-ui!3561 (merged) from being merged into gitlab-ui.

These tests rely on the internal structure of the GlToggle Component by requiring the .gl-toggle class to be a direct descendant of the containing element. This caused issues with gitlab-ui!3561 (merged).

This MR fixes that by allowing .gl-toggle to be an indirect descendant of the GLToggle component.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Janis Altherr

Merge request reports