Skip to content

Improve spec geo_site_form_spec.js

Samantha Ming requested to merge 417642-improve-geo-site-form-spec into master

What does this MR do and why?

This MR addresses the following comment:

  • @cngo started a discussion: (+1 comment)

    I think we generally avoid updating store state like this as it's similar to doing setData after component creation. WDYT about passing in the state to createComponent to initialise the store there? This way we can improve the test code even more while we're here

Screenshots or screen recordings

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #417642 (closed)

Edited by Samantha Ming

Merge request reports