Skip to content

Fix few event types not getting streamed for group push rules changes

Huzaifa Iftikhar requested to merge huzaifaiftikhar1_fix_group_push_rule_event_type_not_streaming into master

What does this MR do and why?

Fix few event types not getting streamed for group push rules changes even though they had an audit event type YML file because these were not added to EVENT_TYPE_PER_ATTR hash in GroupPushRulesChangesAuditor.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Setup audit event streaming destination for a group.
  2. Visit the group setting > repository and then expand the 'Pre-defined push rules' section.
  3. Update the following settings and ensure that a correct event_type is streamed.
    1. Reject unverified users
    2. Reject unsigned commits
    3. Reject commits that aren't DCO certified
    4. Do not allow users to remove Git tags with git push
    5. Check whether the commit author is a GitLab user
    6. Prevent pushing secret files
    7. Branch name (regex)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414569 (closed)

Merge request reports