Skip to content

Duplicate params

Yigit Alparslan requested to merge ya332/gitlab:duplicate-params into master

What does this MR do and why?

Fixes #417547. Reloading the browser and continuing with search produces duplicate params. This is the code that changes the state This is the problematic state: // Change url so if user reload a page - search results are saved const currentPath = this.getPagePath(queryData);

return window.history.replaceState(
  {
    page: currentPath,
  },
  document.title,
  currentPath,
);

Here, instead of getting the url from getPagePath, I am getting the new value of the search string and replacing it.

-->

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports