Refactor resetting events in EventDefinition specs
What does this MR do and why?
In the process of fixing a flaky test that resulted in master:broken in !125174 (merged), a new method was added to Gitlab::InternalEvents::EventDefinitions
as a quick fix to clear the events in the spec.
I replaced that method with clearing the actual instance variable directly and removed the unused method.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Piotr Skorupa