Skip to content

Update related_issues_block_spec.js tests to be faster

Alexander Turinske requested to merge improve-jest-test-time-2 into master

What does this MR do and why?

Update related_issues_block_spec.js tests to be faster

  • After finding out that I can find out how fast a test has run in a pipeline on GitLab, I have made it a personal goal that no test takes more than 1s to run. This is an arbitrary benchmark, but it seems fun
  • user shallowMount instead of mount
  • refactor tests to verify props passed into child component instead of how the props are used in the child component

Related to !125616 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scenario Link Screenshot
Before https://gitlab.com/gitlab-org/gitlab/-/pipelines/923655393/test_report before
After https://gitlab.com/gitlab-org/gitlab/-/pipelines/924763633/test_report after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alexander Turinske

Merge request reports