Skip to content

Add proper handling for props in Vue.js 3 stubs

Illya Klymov requested to merge xanf-fix-weird-options into master

Related issue: #390830 (closed)

What does this MR do and why?

When Vue.js 3 renders an HTML, instead of setting DOM attributes it attemps to set property on DOM node instead. This means that when our stubs (which are rendered as HTML elements) receive props which clash with DOM props which are readonly it will blow-up (with children being the most popular but not the only example

Screenshots or screen recordings

N/A

How to set up and validate locally

VUE_VERSION=3 yarn jest spec/frontend/work_items/components/work_item_links/work_item_link_child_spec.js

it should pass (this is one of the specs which was failing due to that

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Illya Klymov

Merge request reports