Skip to content

Remove redundant wait_until find_element

John McDonnell requested to merge jmd/remove-redundant-wait-squash into master

What does this MR do and why?

Tidy up code here as the looking up and waiting for element squash_checkbox here is redundant as check_element will do a find_element.

How to set up and validate locally

There appear to be just 2 uses of this in the suite

  • bundle exec rspec qa/specs/features/ee/browser_ui/3_create/repository/code_owners_with_protected_branch_and_squashed_commits_spec.rb:65
  • bundle exec rspec qa/specs/features/browser_ui/3_create/merge_request/squash_merge_request_spec.rb:40

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports