Remove diffs app pre-renderer
What does this MR do and why?
This pre-renderer adds additional overhead for the sake of always being able to scroll to the exact same place. Instead of this overhead happening on load of any diffs file this has been moved to our sync component. The sync component scrolls to the right index and then waits for the size to be defined before scrolling again. Doing this means we reduce the amount of time spent on the main thread when loading the page.
Remove the renderIt queue from the diffs app.
The renderIt queue was used before we had the virtual scroller,
with the virtual scroller we are always setting renderIt to
true so the additional time spent by creating callbacks
and calling Vuex commits isn't needed.
Locally this changes to TBT from an average of ~5.2s to an average of ~2s
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.