Fixing elasticsearch_reindexing_spec.rb test according to new UI

What does this MR do?

This MR fixes the elasticsearch_reindexing_spec.rb test which was a stale test.

The test has now been modified for the new navigation. Also cleaned up the legacy code which wasn't used/required.

Linked failure issue: #385927 (closed)

E2E Test Failure issue(s)

Check-list

• General code guidelines check-list
  • Code review guidelines
  • Style guides
• Quarantine test check-list
  • Follow the Quarantining Tests guide.
  • Confirm the test has a quarantine: tag with the specified quarantine type.
  • Note if the test should be quarantined for a specific environment.
  • (Optionally) In case of an emergency (e.g. blocked deployments), consider adding labels to pick into auto-deploy (Pick into auto-deploy priority1 severity1).
• Dequarantine test check-list
  • Follow the Dequarantining Tests guide.
  • Confirm the test consistently passes on the target GitLab environment(s).
• To ensure a faster turnaround, ask in the #quality_maintainers Slack channel for someone to review and merge the merge request, rather than assigning it directly.