Skip to content
Snippets Groups Projects

Geo: Add value transformation logic method

What does this MR do and why?

Simplify how gitlab's geo feature handles registry class name transformations, introduce a new method graphql_enum_key in the BaseRegistry class that encapsulates the value transformation logic.

This is a refactoring change and doesn't affect functionality.

Issue: #414370 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Michael Kozono

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Javiera Tapia requested review from @dbalexandre

    requested review from @dbalexandre

  • Javiera Tapia approved this merge request

    approved this merge request

  • Javiera Tapia removed review request for @jtapiab

    removed review request for @jtapiab

  • removed review request for @dbalexandre

  • Hi @dbalexandre :wave:

    We noticed this MR is marked as workflowready for review but no reviewer is assigned. workflowin dev has automatically been applied to this MR based on the likelihood the review is finished. If additional reviews are still required, please assign a reviewer and reapply workflowready for review.

    @bymayanksingh you may also request a review by commenting @gitlab-bot ready. You can also assign reviewers directly using @gitlab-bot ready @user1 @user2 if you know the relevant reviewer(s), such as those who were involved in a related issue.

    This message was generated automatically. You're welcome to improve it.

  • Mayank Singh added 3 commits

    added 3 commits

    • f9e6fbc9 - Add value transformation logic method
    • 71a63a04 - Add potential rubocop fix for graphql enum key change
    • 76c70644 - Add call to graphql_enum_key in replicator.rb

    Compare with previous version

  • Mayank Singh added 4 commits

    added 4 commits

    • 9fc52622 - Add value transformation logic method
    • 639126ce - Add potential rubocop fix for graphql enum key change
    • 067bf3bf - Add call to graphql_enum_key in replicator.rb
    • d90a0c01 - Add .upcase method, disable cop in registry class enum

    Compare with previous version

  • Mayank Singh changed the description

    changed the description

  • Mayank Singh added 4 commits

    added 4 commits

    • 07935e96 - Add value transformation logic method
    • 48f90677 - Add potential rubocop fix for graphql enum key change
    • 28d7400c - Add call to graphql_enum_key in replicator.rb
    • 7214ad23 - Add .upcase method, disable cop in registry class enum

    Compare with previous version

  • Michael Kozono approved this merge request

    approved this merge request

  • Michael Kozono resolved all threads

    resolved all threads

  • Michael Kozono marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Michael Kozono enabled an automatic merge when the pipeline for 817228f3 succeeds

    enabled an automatic merge when the pipeline for 817228f3 succeeds

  • Contributor

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Minahil Nichols current availability (@minahilnichols) (UTC-4) Luke Duncalfe current availability (@.luke) (UTC+12)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :heavy_minus_sign: test report for 7214ad23

    expand test summary
    +------------------------------------------------------------+
    |                       suites summary                       |
    +-------+--------+--------+---------+-------+-------+--------+
    |       | passed | failed | skipped | flaky | total | result |
    +-------+--------+--------+---------+-------+-------+--------+
    +-------+--------+--------+---------+-------+-------+--------+
    | Total | 0      | 0      | 0       | 0     | 0     | ➖     |
    +-------+--------+--------+---------+-------+-------+--------+
  • merged

  • @bymayanksingh, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. React with a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Michael Kozono mentioned in commit 114c582f

    mentioned in commit 114c582f

  • added workflowstaging label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading